feat: port bi/lib/counterexamples.v (+ fix IntoWand instances) - #540
Open
alvinylt wants to merge 24 commits into
Open
feat: port bi/lib/counterexamples.v (+ fix IntoWand instances)#540alvinylt wants to merge 24 commits into
bi/lib/counterexamples.v (+ fix IntoWand instances)#540alvinylt wants to merge 24 commits into
Conversation
…`IntoWand` instances
alvinylt
commented
Jul 27, 2026
Comment on lines
+257
to
+259
| /- Necessary to unfold `▷^[n + 1]` as `▷ ▷^[n]`, or else we get | ||
| `∗Hfalse : ▷^[n + 1] False` after `imod`. -/ | ||
| icases (later_laterN n).mp $$ Hfalse with Hfalse |
Contributor
Author
There was a problem hiding this comment.
We have to unfold laterN manually in order for imod to produce the correct hypothesis.
Might be interesting to investigate the cause.
alvinylt
marked this pull request as ready for review
July 27, 2026 17:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports
bi/lib/counterexamples.v.Addresses #206.
Each
Modulein the Rocq version corresponds to anamespaceinBI/Lib/Counterexamples.lean.affine_em:AffineEMlöb_em:LoebEMsavedpropinvinv1inv2linearlater_credits_plainFixing
IntoWandInstancesThere is a comment above the existing type class instances
intoWand_imp_falseandintoWand_imp_true:At one point within the proof of
later_anything, we come across the following proof state:With the existing two instances, we are unable to use
ispecialize HnotP $$ IHto solve the goal.The instance
intoWand_imp_truestipulatesAffine (▷ False), which does not hold. The type class instanceinto_wand_impl_true_true, on the other hand, has no such requirement. The instancesintoWand_impl_false_trueandintoWand_impl_false_falsealso come with different assumptions.The two instances are therefore replaced by those directly corresponding to the formulation in Rocq.
Checklist
authorssection of any appropriate files