Skip to content

feat: Vectors of rFunctors - #76

Closed
Remyjck wants to merge 45 commits into
leanprover-community:masterfrom
Remyjck:rfunctors
Closed

feat: Vectors of rFunctors#76
Remyjck wants to merge 45 commits into
leanprover-community:masterfrom
Remyjck:rfunctors

Conversation

@Remyjck

@Remyjck Remyjck commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

Here is an ongoing attempt to add extensible vectors of rFunctors #37

@markusdemedeiros

Copy link
Copy Markdown
Collaborator

Great start on this :)

One thing I'm thinking about: I'm replacing GenMapOF in my heaps PR to support heaps with infinitely many allocated elements. I'm doing this for other reasons, but because the iProp construction is based on GenMapOF, I'm wondering how much the rest of the inG machinery depends on the number of pieces of ghost state being finite?

@Remyjck

Remyjck commented Jul 21, 2025

Copy link
Copy Markdown
Contributor Author

I think/hope that as long as you carry around a witness that your index is valid (what is being done by GId here), then it should be fine to have infinite pieces of ghost state.

FYI, I do not plan on working on this for the next few weeks, but if/when I do, I would like to swap out Array in the definition of GFunctors with the generalization of gmap from #63

@markusdemedeiros

Copy link
Copy Markdown
Collaborator

Good to know! FYI, before you start working on it again, you should discuss with Mario about if we should stick to the Array definition or the Heaps definition. I think the Heaps definition is super interesting, but we don't want to make the rest of the port too much harder on ourselves.

@Remyjck
Remyjck marked this pull request as draft July 22, 2025 14:11
@markusdemedeiros

Copy link
Copy Markdown
Collaborator

@Remyjck Is it alright with you if adopt this feature? I am starting to work on it in #92.

@Remyjck

Remyjck commented Oct 1, 2025

Copy link
Copy Markdown
Contributor Author

Sorry, I didn't see this until now!
Please go ahead, I haven't given this much thought for a while.

I'm curious to see how this is resolved, I spent quite some time struggling to get the right camera instances bundled in the right places.

Remyjck and others added 22 commits November 5, 2025 14:52
Co-authored-by: Joe Watt <joewatt95@u.nus.edu>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4...v5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Implement a CMRA for a generic type of heaps
---------

Co-authored-by: ahuoguo <ahuoguo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants