Skip to content

[Merged by Bors] - feat(RingTheory): smooth algebras have smooth Noetherian models#25143

Closed
chrisflav wants to merge 10 commits intomasterfrom
chrisflav-algebratensoralgequiv.2
Closed

[Merged by Bors] - feat(RingTheory): smooth algebras have smooth Noetherian models#25143
chrisflav wants to merge 10 commits intomasterfrom
chrisflav-algebratensoralgequiv.2

Conversation

@chrisflav
Copy link
Copy Markdown
Member

@chrisflav chrisflav commented May 24, 2025

@chrisflav chrisflav added the t-algebra Algebra (groups, rings, fields, etc) label May 24, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 24, 2025

PR summary 920783b3b4

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.RingTheory.MvPolynomial.Homogeneous 996 1008 +12 (+1.20%)
Import changes for all files
Files Import difference
6 files Mathlib.Algebra.Lie.CartanExists Mathlib.Algebra.Lie.Rank Mathlib.Algebra.Module.LinearMap.Polynomial Mathlib.Algebra.MvPolynomial.Nilpotent Mathlib.Combinatorics.Nullstellensatz Mathlib.LinearAlgebra.Matrix.Charpoly.Univ
1
Mathlib.RingTheory.MvPolynomial.Ideal 5
3 files Mathlib.RingTheory.MvPolynomial.Groebner Mathlib.RingTheory.MvPolynomial.MonomialOrder.DegLex Mathlib.RingTheory.MvPolynomial.MonomialOrder
11
3 files Mathlib.Algebra.Polynomial.Homogenize Mathlib.RingTheory.MvPolynomial.EulerIdentity Mathlib.RingTheory.MvPolynomial.Homogeneous
12
Mathlib.RingTheory.Smooth.NoetherianDescent (new file) 1472

Declarations diff

+ C_mul
+ DescentAux
+ Ideal.mem_span_iff_exists_isHomogeneous
+ Ideal.mem_span_pow_iff_exists_isHomogeneous
+ Ideal.span_eq_map_homogeneousSubmodule
+ Ideal.span_pow_eq_map_homogeneousSubmodule
+ _root_.AlgHom.kerSquareLift_mk
+ algebra₀
+ algebra₁
+ algebra₂
+ coeffs_h_subset
+ coeffs_p_subset
+ coeffs_q_subset
+ eval₂_map_comp_C
+ exists_kerSquareLift_comp_eq_id
+ hasCoeffs
+ homogeneousSubmodule_one_eq_span_X
+ homogeneousSubmodule_one_pow
+ homogeneousSubmodule_zero
+ induction_on
+ instance : CommRing (D.subalgebra R) := inferInstanceAs <| CommRing (Algebra.adjoin _ _)
+ instance : FaithfulSMul (D.subalgebra R) A := inferInstanceAs <| FaithfulSMul (Algebra.adjoin _ _) _
+ instance : IsScalarTower (D.subalgebra R) A B
+ instance [Finite D.vars] [Finite D.rels] : Algebra.FiniteType R (D.subalgebra R) := by
+ map_eval
+ monomial_mem_homogeneousSubmodule_pow_degree
+ of_map
+ range_single_one
+ subalgebra

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 24, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 25, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@grunweg grunweg added t-ring-theory Ring theory and removed t-algebra Algebra (groups, rings, fields, etc) labels Aug 5, 2025
@chrisflav chrisflav force-pushed the chrisflav-algebratensoralgequiv.2 branch from 9b2c2a9 to 82b142b Compare November 25, 2025 05:23
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 25, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Nov 25, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

This PR/issue depends on:

@erdOne erdOne added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 29, 2025
@chrisflav chrisflav removed the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 4, 2025
@erdOne erdOne added the awaiting-author A reviewer has asked the author a question or requested changes. label Dec 6, 2025
@chrisflav chrisflav added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Dec 8, 2025
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Dec 8, 2025
Copy link
Copy Markdown
Member

@erdOne erdOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 8, 2025

🚀 Pull request has been placed on the maintainer queue by erdOne.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Dec 8, 2025
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 9, 2025

✌️ chrisflav can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Dec 9, 2025
chrisflav and others added 2 commits December 9, 2025 13:32
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
@chrisflav
Copy link
Copy Markdown
Member Author

Thanks for the reviews!

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Dec 9, 2025
Co-authored by: Judith Ludwig <ludwig@mathi.uni-heidelberg.de>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 9, 2025

Build failed:

@chrisflav
Copy link
Copy Markdown
Member Author

bors r-

@chrisflav
Copy link
Copy Markdown
Member Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Dec 9, 2025
Co-authored by: Judith Ludwig <ludwig@mathi.uni-heidelberg.de>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Dec 9, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory): smooth algebras have smooth Noetherian models [Merged by Bors] - feat(RingTheory): smooth algebras have smooth Noetherian models Dec 9, 2025
@mathlib-bors mathlib-bors bot closed this Dec 9, 2025
@mathlib-bors mathlib-bors bot deleted the chrisflav-algebratensoralgequiv.2 branch December 9, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants