[Merged by Bors] - feat(RingTheory): smooth algebras have smooth Noetherian models#25143
[Merged by Bors] - feat(RingTheory): smooth algebras have smooth Noetherian models#25143
Conversation
PR summary 920783b3b4
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.MvPolynomial.Homogeneous | 996 | 1008 | +12 (+1.20%) |
Import changes for all files
| Files | Import difference |
|---|---|
6 filesMathlib.Algebra.Lie.CartanExists Mathlib.Algebra.Lie.Rank Mathlib.Algebra.Module.LinearMap.Polynomial Mathlib.Algebra.MvPolynomial.Nilpotent Mathlib.Combinatorics.Nullstellensatz Mathlib.LinearAlgebra.Matrix.Charpoly.Univ |
1 |
Mathlib.RingTheory.MvPolynomial.Ideal |
5 |
3 filesMathlib.RingTheory.MvPolynomial.Groebner Mathlib.RingTheory.MvPolynomial.MonomialOrder.DegLex Mathlib.RingTheory.MvPolynomial.MonomialOrder |
11 |
3 filesMathlib.Algebra.Polynomial.Homogenize Mathlib.RingTheory.MvPolynomial.EulerIdentity Mathlib.RingTheory.MvPolynomial.Homogeneous |
12 |
Mathlib.RingTheory.Smooth.NoetherianDescent (new file) |
1472 |
Declarations diff
+ C_mul
+ DescentAux
+ Ideal.mem_span_iff_exists_isHomogeneous
+ Ideal.mem_span_pow_iff_exists_isHomogeneous
+ Ideal.span_eq_map_homogeneousSubmodule
+ Ideal.span_pow_eq_map_homogeneousSubmodule
+ _root_.AlgHom.kerSquareLift_mk
+ algebra₀
+ algebra₁
+ algebra₂
+ coeffs_h_subset
+ coeffs_p_subset
+ coeffs_q_subset
+ eval₂_map_comp_C
+ exists_kerSquareLift_comp_eq_id
+ hasCoeffs
+ homogeneousSubmodule_one_eq_span_X
+ homogeneousSubmodule_one_pow
+ homogeneousSubmodule_zero
+ induction_on
+ instance : CommRing (D.subalgebra R) := inferInstanceAs <| CommRing (Algebra.adjoin _ _)
+ instance : FaithfulSMul (D.subalgebra R) A := inferInstanceAs <| FaithfulSMul (Algebra.adjoin _ _) _
+ instance : IsScalarTower (D.subalgebra R) A B
+ instance [Finite D.vars] [Finite D.rels] : Algebra.FiniteType R (D.subalgebra R) := by
+ map_eval
+ monomial_mem_homogeneousSubmodule_pow_degree
+ of_map
+ range_single_one
+ subalgebra
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
|
This pull request has conflicts, please merge |
9b2c2a9 to
82b142b
Compare
|
This PR/issue depends on: |
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
|
✌️ chrisflav can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
|
Thanks for the reviews! bors r+ |
Co-authored by: Judith Ludwig <ludwig@mathi.uni-heidelberg.de>
|
Build failed: |
|
bors r- |
|
bors r+ |
Co-authored by: Judith Ludwig <ludwig@mathi.uni-heidelberg.de>
|
Pull request successfully merged into master. Build succeeded: |
Co-authored by: Judith Ludwig ludwig@mathi.uni-heidelberg.de