Skip to content

chore(Combinatorics/Enumerative/Catalan): split into Basic & Tree#34854

Open
GrigorenkoPV wants to merge 2 commits intoleanprover-community:masterfrom
GrigorenkoPV:catalan_chore
Open

chore(Combinatorics/Enumerative/Catalan): split into Basic & Tree#34854
GrigorenkoPV wants to merge 2 commits intoleanprover-community:masterfrom
GrigorenkoPV:catalan_chore

Conversation

@GrigorenkoPV
Copy link
Copy Markdown
Contributor


Split off from #34853

Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Feb 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2026

PR summary ea9c91472b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Combinatorics.Enumerative.DyckWord 1
Mathlib.Combinatorics.Enumerative.Catalan 2
Mathlib.Combinatorics.Enumerative.Catalan.Basic (new file) 808
Mathlib.Combinatorics.Enumerative.Catalan.Tree (new file) 809

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@GrigorenkoPV GrigorenkoPV changed the title chore(Combinatorics/Enumerative/Catalan): split into Basic & tree chore(Combinatorics/Enumerative/Catalan): split into Basic & Tree Feb 4, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 18, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 18, 2026
Copy link
Copy Markdown
Collaborator

@vihdzp vihdzp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me, though I'm curious, what's the motivation? Is it imports? File length? Something else?

@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 24, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 17, 2026
@Multramate Multramate added the t-combinatorics Combinatorics label Apr 2, 2026
Co-authored-by: Violeta Hernández Palacios <vi.hdz.p@gmail.com>
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

maintainer merge

@YaelDillies YaelDillies removed their assignment Apr 12, 2026
@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-combinatorics Combinatorics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants