Skip to content

WIP#37002

Open
fbarroero wants to merge 11 commits intoleanprover-community:masterfrom
fbarroero:fbarroero_intMinpoly
Open

WIP#37002
fbarroero wants to merge 11 commits intoleanprover-community:masterfrom
fbarroero:fbarroero_intMinpoly

Conversation

@fbarroero
Copy link
Copy Markdown
Collaborator

WIP


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 22, 2026

PR summary 3d8100bbc6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ aux_ne_zero
+ normalizedPrimPartIntegerNormalization
+ normalizedPrimPartIntegerNormalization_IsPrimtive
+ normalizedPrimPartIntegerNormalization_degree_eq
+ normalizedPrimPartIntegerNormalization_dvd
+ normalizedPrimPartIntegerNormalization_dvd'
+ normalizedPrimPartIntegerNormalization_eq_zero_iff
+ normalizedPrimPartIntegerNormalization_irreducible_iff
+ normalizedPrimPartIntegerNormalization_ne_zero

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-ring-theory Ring theory label Mar 22, 2026
@github-actions
Copy link
Copy Markdown

🚨 PR Title Needs Formatting

Please update the title to match our commit style conventions.

Errors from script:

error: the PR title does not contain a colon
Details on the required title format

The title should fit the following format:

<kind>(<optional-scope>): <subject>

<kind> is:

  • feat (feature)
  • fix (bug fix)
  • doc (documentation)
  • style (formatting, missing semicolons, ...)
  • refactor
  • test (when adding missing tests)
  • chore (maintain)
  • perf (performance improvement, optimization, ...)
  • ci (changes to continuous integration, repo automation, ...)

<optional-scope> is a name of module or a directory which contains changed modules.
This is not necessary to include, but may be useful if the <subject> is insufficient.
The Mathlib directory prefix is always omitted.
For instance, it could be

  • Data/Nat/Basic
  • Algebra/Group/Defs
  • Topology/Constructions

<subject> has the following constraints:

  • do not capitalize the first letter
  • no dot(.) at the end
  • use imperative, present tense: "change" not "changed" nor "changes"

@fbarroero fbarroero added the WIP Work in progress label Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ring-theory Ring theory WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant