Skip to content

feat(Geometry/Convex/Cone): Minor additions to pointed cones#37464

Open
martinwintermath wants to merge 6 commits intoleanprover-community:masterfrom
martinwintermath:pointed-minor
Open

feat(Geometry/Convex/Cone): Minor additions to pointed cones#37464
martinwintermath wants to merge 6 commits intoleanprover-community:masterfrom
martinwintermath:pointed-minor

Conversation

@martinwintermath
Copy link
Copy Markdown
Contributor

@martinwintermath martinwintermath commented Mar 31, 2026

Minor additions to pointed cones:

  • PointedCone.ofSubmodule_le_ofSubmodule and PointedCone.ofSubmodule_lt_ofSubmodule
  • PointedCone.hull_le_span as a short form of Submodule.span_le_restrictScalars R≥0 R s
  • PointedCone.neg_ofSubmodule proving -(ofSubmodule S) = S

In preparation for #36605.

Co-authored by: Artie Khovanov


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

PR summary c290b55c6e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ hull_le_span
+ neg_ofSubmodule
+ ofSubmodule_le_ofSubmodule
+ ofSubmodule_lt_ofSubmodule

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Increase in tech debt: (relative, absolute) = (3.00, 0.00)
Current number Change Type
6756 3 backward.isDefEq.respectTransparency

Current commit 55616981e6
Reference commit c290b55c6e

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-convex-geometry Affine geometry, cones, simplices label Mar 31, 2026
@martinwintermath martinwintermath marked this pull request as ready for review March 31, 2026 22:30
@ooovi ooovi added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 1, 2026
@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 1, 2026
@artie2000 artie2000 added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 1, 2026
Co-authored-by: ooovi <79147175+ooovi@users.noreply.github.com>
@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-convex-geometry Affine geometry, cones, simplices

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants