Skip to content

feat(Category/Kernel): SFinKer morphisms are deterministic#37851

Open
gaetanserre wants to merge 8 commits intoleanprover-community:masterfrom
gaetanserre:kernel_categories
Open

feat(Category/Kernel): SFinKer morphisms are deterministic#37851
gaetanserre wants to merge 8 commits intoleanprover-community:masterfrom
gaetanserre:kernel_categories

Conversation

@gaetanserre
Copy link
Copy Markdown
Collaborator

@gaetanserre gaetanserre commented Apr 9, 2026

Add several Deterministic instances for SFinKer and Stoch associators, unitors, braiding, counit, and comul morphisms.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

PR summary b6c608e112

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Probability.Kernel.Category.SFinKer 1672 1673 +1 (+0.06%)
Mathlib.Probability.Kernel.Category.Stoch 1692 1693 +1 (+0.06%)
Import changes for all files
Files Import difference
Mathlib.Probability.Kernel.Category.SFinKer Mathlib.Probability.Kernel.Category.Stoch 1

Declarations diff

+ deterministic_Deterministic
+ id_map_Deterministic
+ instance : Deterministic (λ_ X ).hom
+ instance : Deterministic (λ_ X).hom
+ instance : Deterministic (ρ_ X ).hom
+ instance : Deterministic (ρ_ X).hom
++ instance : Deterministic (Δ[X])
++ instance : Deterministic (α_ X Y Z).hom
++ instance : Deterministic (β_ X Y).hom
++ instance : Deterministic (ε[X])

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@github-actions github-actions bot added the t-measure-probability Measure theory / Probability theory label Apr 9, 2026
@gaetanserre gaetanserre changed the title Kernel categories feat(Category/Kernel): SFinKer morphisms are deterministic Apr 9, 2026
@gaetanserre gaetanserre changed the title feat(Category/Kernel): SFinKer morphisms are deterministic feat(Category/Kernel): SFinKer morphisms are deterministic Apr 9, 2026
@gaetanserre gaetanserre added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Apr 9, 2026
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Apr 9, 2026
@EtienneC30 EtienneC30 added the t-category-theory Category theory label Apr 11, 2026

variable {X Y Z : SFinKer}

instance : Deterministic (α_ X Y Z).hom :=
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all isomorphisms deterministic? Or if e is an isomorphism, is it true that e.inv is deterministic if e.hom is? In any case, I would think we would like to know that not only (α_ X Y Z).hom is a deterministic, but also (α_ X Y Z).inv, and similarly for the unitors.

Copy link
Copy Markdown
Collaborator Author

@gaetanserre gaetanserre Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or if e is an isomorphism, is it true that e.inv is deterministic if e.hom is?

Indeed, thanks to instIsComonHomInvOfHom, the instances for .inv are automatically inferred.

@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 11, 2026
@gaetanserre gaetanserre removed the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 11, 2026
@gaetanserre
Copy link
Copy Markdown
Collaborator Author

awaiting-author

@github-actions github-actions bot added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. t-category-theory Category theory t-measure-probability Measure theory / Probability theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants