Skip to content

feat: transfer star-related instances across equivalences#37914

Open
j-loreaux wants to merge 1 commit intoleanprover-community:masterfrom
j-loreaux:transfer-star
Open

feat: transfer star-related instances across equivalences#37914
j-loreaux wants to merge 1 commit intoleanprover-community:masterfrom
j-loreaux:transfer-star

Conversation

@j-loreaux
Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux commented Apr 10, 2026

This also adds Function.Injective.{InvolutiveStar,...} and related lemmas.

In addition we rename the existing Equiv.star to Equiv.Perm.star (without a deprecation) so that the name can be used for the declaration which transfers a Star instance across an Equiv.


Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary 61a15581d4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Algebra.Star.TransferInstance (new file) 515

Declarations diff

+ Equiv.Perm.star
+ InvolutiveStar
+ involutiveStar
+ star
++ starAddMonoid
++ starMul
++ starRing
- Equiv.star

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Apr 10, 2026
star r := e.symm (star (e r))

/-- Transfer `InvolutiveStar` across an `Equiv` -/
protected abbrev InvolutiveStar [InvolutiveStar S] : InvolutiveStar R :=
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean?

Suggested change
protected abbrev InvolutiveStar [InvolutiveStar S] : InvolutiveStar R :=
protected abbrev involutiveStar [InvolutiveStar S] : InvolutiveStar R :=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants