Skip to content

feat(Topology/FiberBundle): continuousWithinAt_section and continuousAt_section#37945

Open
Deicyde wants to merge 2 commits intoleanprover-community:masterfrom
Deicyde:continuousAt-section
Open

feat(Topology/FiberBundle): continuousWithinAt_section and continuousAt_section#37945
Deicyde wants to merge 2 commits intoleanprover-community:masterfrom
Deicyde:continuousAt-section

Conversation

@Deicyde
Copy link
Copy Markdown
Contributor

@Deicyde Deicyde commented Apr 12, 2026

These lemmas are analogous to contMDiffWithinAt_section and contMDiffAt_section for smooth vector bundles.


AI Use: Claude was used to help write the precise proof terms.
The overall API was designed to exactly mimic the existing contMDiff analogues.


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Apr 12, 2026
@github-actions
Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 12, 2026

PR summary 3be903dc33

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ continuousAt_section
+ continuousWithinAt_section

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Apr 12, 2026
@Deicyde Deicyde changed the title Added continuousWithinAt_section and continuousAt_section Feat(Topology/FiberBundle): continuousWithinAt_section and continuousAt_section Apr 12, 2026
@Deicyde
Copy link
Copy Markdown
Contributor Author

Deicyde commented Apr 12, 2026

easy

@github-actions github-actions bot added the easy < 20s of review time. See the lifecycle page for guidelines. label Apr 12, 2026
@Deicyde Deicyde marked this pull request as ready for review April 12, 2026 11:11
@grunweg grunweg changed the title Feat(Topology/FiberBundle): continuousWithinAt_section and continuousAt_section feat(Topology/FiberBundle): continuousWithinAt_section and continuousAt_section Apr 12, 2026
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have slightly different proof terms in mind --- my take-away is to look at the analogous proof to see if there are improvements to be had.

theorem continuousWithinAt_section {s : ∀ x, E x} {a : Set B} {x₀ : B} :
ContinuousWithinAt (fun x ↦ TotalSpace.mk' F x (s x)) a x₀ ↔
ContinuousWithinAt (fun x ↦ (trivializationAt F E x₀ ⟨x, s x⟩).2) a x₀ :=
continuousWithinAt_totalSpace (F := F) _ |>.trans (and_iff_right continuousWithinAt_id)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it's a good idea to compare with the analogous proof, to see which version is better.
I find simp_rw [continuousWithinAt_totalSpace, and_iff_right_iff_imp]; intro; exact continuousWithinAt_id slightly nicer.

theorem continuousAt_section {s : ∀ x, E x} (x₀ : B) :
ContinuousAt (fun x ↦ TotalSpace.mk' F x (s x)) x₀ ↔
ContinuousAt (fun x ↦ (trivializationAt F E x₀ ⟨x, s x⟩).2) x₀ :=
continuousAt_totalSpace (F := F) _ |>.trans (and_iff_right continuousAt_id)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This proof reduces to the withinAt version, which is often a good idea:

Suggested change
continuousAt_totalSpace (F := F) _ |>.trans (and_iff_right continuousAt_id)
simp_rw [← contMDiffWithinAt_univ]; exact contMDiffWithinAt_section

@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. easy < 20s of review time. See the lifecycle page for guidelines. new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants