refactor: reorder Triple to program-first#14103
Merged
Merged
Conversation
github-actions
Bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This PR reorders the arguments of `Triple` so the program comes first: `Triple pre x post epost` becomes `Triple x pre post epost`. The program now drives elaboration, so its monad and return type are fixed before the pre- and postconditions are elaborated. Test consumers are switched to the `⦃ … ⦄` notation where possible, which is insulated from the argument order. The remaining raw uses keep a generic `epost` variable or a custom assertion lattice without a `⊥`, neither of which the notation can express.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reorders the arguments of
Tripleso the program comes first:Triple pre x post epostbecomesTriple x pre post epost. The program now drives elaboration, so its monad and return type are fixed before the pre- and postconditions are elaborated.