Open
Conversation
This setups up the Elastic Stack and runs the install command against it to ensure package is not only validated but can also be installed.
legrego
reviewed
Sep 4, 2023
Owner
legrego
left a comment
legrego
left a comment
There was a problem hiding this comment.
The setup/install steps don't feel related to "coding style". What do you think about either renaming the job to be more generic, or creating a separate job within this action for these new steps?
Collaborator
Author
|
I started to play around with this here: ruflin/ruflin-integration-package#6 I like the idea of having a separate step as then it shows up also under checks in 2 rows. But right now I repeat too much code, I'm sure there is a better way. Need to read up a bit on Github actions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This setups up the Elastic Stack and runs the install command against it to ensure package is not only validated but can also be installed.