Skip to content

fix: short-circuit get_master_token() when master_token already stored #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
githubhjs wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: short-circuit get_master_token() when master_token already stored #1042

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions custom_components/google_home/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,12 @@ async def async_get_master_token(self) -> str:
"""Get master API token."""

def _get_master_token() -> str | None:
# glocaltokens 0.7.6 bug: get_master_token() returns None when
# password=None even if master_token is already stored, because
# it checks `if self.username is None or self.password is None`
# before inspecting the stored token. Short-circuit that here.
if self._client.master_token and is_aas_et(self._client.master_token):
return self._client.master_token
return self._client.get_master_token()

master_token = await self.hass.async_add_executor_job(_get_master_token)
Expand Down
Loading