Open
Conversation
This reverts commit 73165f9.
This reverts commit 84c26ff.
…then checking the results. The timeout on the start scan command is actually how long to scan for, so really longer is actually better. But I don't know if there is issues with having it run forever. The other problem is that you either have it set to clear_results or not, if false it never clears out devices that are no longer visible which doesn't work cause we can't tell if a device is gone. But if its true a device if it misses one scan it will go unavailable right away and might not show up a while later. So to solve this I do a clear_results every minute. But I am also using last_seen to not set a device as gone until that point. I could probably just do the last_seen, but I think both together seems safer at least to start.
…then checking the results. The timeout on the start scan command is actually how long to scan for, so really longer is actually better. But I don't know if there is issues with having it run forever. The other problem is that you either have it set to clear_results or not, if false it never clears out devices that are no longer visible which doesn't work cause we can't tell if a device is gone. But if its true a device if it misses one scan it will go unavailable right away and might not show up a while later. So to solve this I do a clear_results every minute. But I am also using last_seen to not set a device as gone until that point. I could probably just do the last_seen, but I think both together seems safer at least to start.
…then checking the results. The timeout on the start scan command is actually how long to scan for, so really longer is actually better. But I don't know if there is issues with having it run forever. The other problem is that you either have it set to clear_results or not, if false it never clears out devices that are no longer visible which doesn't work cause we can't tell if a device is gone. But if its true a device if it misses one scan it will go unavailable right away and might not show up a while later. So to solve this I do a clear_results every minute. But I am also using last_seen to not set a device as gone until that point. I could probably just do the last_seen, but I think both together seems safer at least to start.
Owner
|
@KapJI , do you have a capacity to help with the review here? |
Author
|
@Lash-L Were you able to successfully test IRK based tracking in your PR? Its not working for me and would appreciate any guidance. |
I'm pretty sure i did, as I did most of my testing with my iphone. I can't remember what i did and it has been so long I am not familiar with the code anymore though, so I don't think i would be much help. |
|
Something new? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #891