fix(lns-service): disclose env var + destination domain on credential approval card (M10)

[lens-bot-mirantis]

M10: credential approval card must disclose env var + destination domain

Problem

The credential approval card showed only the provider id and a generic action string. It hid which host env var is read and which domain the credential is sent to. Because a project's lns-policy.yaml controls the provider id, the env var, and the injection domain, a developer could be socially engineered into approving a custom (project-defined) provider that exfiltrates a host secret to an attacker-controlled domain — the card gave them nothing to notice the mismatch.

Fix

Thread the resolved provider's disclosure data to the approval card and render it:

• Reads host env: $X — the env var the provider reads
• Sends to: <domain[, domain]> — deduped/sorted injection domains
• ⚠ Project-defined provider (not built-in) — warning-colored, shown when the provider id is not in the bundled set

Host-side only. No wire-protocol / guest-facing change.

Changes

• protocol.rs — CredentialInjection::domain() accessor.
• session.rs — env_var/injection_domains/is_project_defined on CredentialPendingPrompt (+ SignInPrompt); bundled_ids field + with_bundled_ids builder; provider_disclosure() helper; wired through submit_pending, run_pkce_connect, run_oauth_connect.
• window.rs — same fields on CredentialCardPrompt + SignInCard, threaded in insert_credential_pending; TEXT_WARN color.
• notification.rs — threads fields SignInPrompt → SignInCard.
• adapter.rs — wires bundled integration ids via .with_bundled_ids(...).
• tray.rs — renders the three disclosure labels on the card.
• watcher.rs — test constructions updated.

Tests

Regression tests at session / window / notifier layers:

• submit_pending threads env_var + domains for a custom provider; is_project_defined is true when the id is not bundled, false when it is; env_var stays None for an unknown credential id.
• insert_credential_pending carries the fields through to the snapshot.
• present() passes the fields to the card.

Verification note

cargo fmt --all --check and cargo check --package lns-policy pass locally. The full lns-service build + test runs in CI — it links egui/GTK, and this sandbox can't install the GTK/glib system libs, so the authoritative build/test for this crate is CI.

Addresses security finding M10.

[Copilot]

Pull request overview

This PR addresses security finding M10 by enriching the lns-service credential approval UI so developers can see (a) which host env var will be read and (b) which destination domain(s) a credential may be sent to, plus a warning when the provider/integration is not part of the bundled set.

Changes:

• Thread provider disclosure fields (env_var, injection_domains, is_project_defined) through the credential/session → window/notification → tray rendering pipeline.
• Add a CredentialInjection::domain() accessor to extract/collect destination domains for disclosure.
• Wire bundled integration IDs into the credential session so the UI can distinguish bundled vs non-bundled providers.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
crates/lns-service/src/tray.rs	Renders “Reads host env”, “Sends to”, and non-bundled warning labels on credential cards.
crates/lns-service/src/supervisor/adapter.rs	Supplies bundled integration IDs into the credential subsystem via .with_bundled_ids(...).
crates/lns-service/src/credential_flow/watcher.rs	Updates test fixtures to include newly added prompt fields.
crates/lns-service/src/credential_flow/session.rs	Adds disclosure fields to prompts, stores bundled IDs, and derives disclosure data from provider injections.
crates/lns-service/src/credential_flow/notification.rs	Threads new sign-in disclosure fields into the window notifier.
crates/lns-service/src/approval_flow/window.rs	Carries disclosure fields into window-state prompt/card models and adds TEXT_WARN.
crates/lns-service/src/approval_flow/protocol.rs	Adds CredentialInjection::domain() accessor used to collect injection domains for disclosure.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.