feat(frontend): harden banks API and instrument status telemetry - #1288
Merged
github-actions[bot] merged 5 commits intoJul 26, 2026
Merged
Conversation
|
@Anthony-19 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…ony-19/Stellar-Dex-Chat into feat/add_request_validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/banksquery parameters with Zod and return a machine-readableINVALID_REQUESTerror on invalid input/api/banks, with unit coverage for quota rejectionmake cito run the frontend and contract CI matrix locallyRationale
Contributors previously had to reconstruct checks from several workflow files.
make ciprovides one local entry point covering the same validation categories: frontend typecheck, lint, build, coverage, E2E, and contract test/build/clippy.Testing
git diff --check✅pnpm typecheck,pnpm lint, andpnpm test:unitcould not be executed locally because dependency installation exceeded the environment time limit before completion.Closes #1276
Closes #1265
Closes #1206
Closes #1205