fix(frontend): resolve stale closure in chatSearch.ts debounce (#1225) - #1292
Merged
github-actions[bot] merged 1 commit intoJul 27, 2026
Conversation
…y-net#1225) Root cause: debounce() captured fn at creation time via closure. If the caller's callback was recreated on each render the debounced wrapper kept calling the original (stale) fn. Timer ref was also never reset to null after firing, leaving a dangling ID. Fix: - Store latestFn internally; expose updateFn() so callers can swap the callback without recreating the debounced wrapper. - Reset timer = null inside the timeout callback. - Add cancel() so callers can abort pending timers on unmount. Regression tests cover all three failure modes.
|
@Mercy017 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
debounce()inchatSearch.tshad three related bugs:fnclosure —fnwas captured atdebounce()call time and never updated. When callers recreated their callback (e.g. an inline arrow function on each render), the debounced wrapper kept calling the original, stale function.timerreference —timerwas never reset tonullafter the timeout fired. FutureclearTimeout(timer)calls operated on an already-expired ID, giving a false sense of cancellation.cancel()method — there was no way for a caller to abort a pending invocation on component unmount, causing callbacks to fire against unmounted state.Fix (
src/lib/chatSearch.ts)latestFnvariable insidedebounce; addedupdateFn(newFn)on the returned function so callers can swap the underlying callback without rebuilding the debounced wrapper.timer = nullis now set inside thesetTimeoutcallback so the reference is always accurate.cancel()method that clears and nulls the pending timer.DebouncedFn<T>interface for typed usage.Regression tests (
src/lib/chatSearch.test.ts)Six new tests under
describe('debounce')covering:updateFncalls the new fn, not the original (stale-closure regression)cancel()prevents firingCloses #1225
Closes #1223