Skip to content

feat(frontend): add CCIP bridge ARIA labels - #903

Draft
kongwen686 wants to merge 765 commits into
leojay-net:mainfrom
kongwen686:feat/ccip-aria-labels
Draft

feat(frontend): add CCIP bridge ARIA labels#903
kongwen686 wants to merge 765 commits into
leojay-net:mainfrom
kongwen686:feat/ccip-aria-labels

Conversation

@kongwen686

Copy link
Copy Markdown

Summary

  • replace the modal's generic aria-label with aria-labelledby and aria-describedby tied to visible copy
  • add accessible names for the close/start actions and explorer links
  • announce transfer state changes with status/alert semantics and hide decorative icons from assistive tech
  • add accessibility regression coverage for the modal and stabilize the CCIP modal timer tests under the current Vitest setup

Closes #689

Validation

  • npm run test:unit -- src/components/__tests__/CCIPBridgeModal.test.tsx
  • npm run typecheck
  • npx prettier --check src/components/CCIPBridgeModal.tsx src/components/__tests__/CCIPBridgeModal.test.tsx

Anthony-19 and others added 30 commits March 29, 2026 18:49
…-net#294, leojay-net#301

- fix(contract): emit event in set_operator for off-chain monitoring (leojay-net#390)
- feat(frontend): add CSV export to ReceiptDrawer with accessible button (leojay-net#391)
- feat(frontend): add Zod validation schemas for all API route inputs (leojay-net#294)
- fix(frontend): deduplicate chat history entries on page reload (leojay-net#301)

Changes:
- Added event emission in set_operator function with EVENT_VERSION
- Implemented CSV export functionality in ReceiptDrawer with proper escaping
- Created apiSchemas.ts with Zod schemas for create-recipient, initiate-transfer, and verify-account
- Updated all API routes to use Zod validation with structured error responses
- Added deduplicateSessions method to ChatHistoryManager
- Updated loadFromLocalStorage to deduplicate sessions on load
- Updated createNewSession to deduplicate before saving
- Added unit tests for deduplication logic
- Fixed duplicate section in ChatHistorySidebar

All tests passing, lint checks clean.
- Change error.errors to error.issues (correct Zod API)
- Fix TransactionAmountDisplay import (named export)
- Update CSV export to use correct TransactionHistoryEntry properties
- Remove duplicate imports in ReceiptDrawer
…196-187

feat: add split-view comparison, advanced search, and markdown hardening
…y-consent-toggle

feat(frontend): add telemetry consent toggle in user settings
…draft-messages

feat(frontend): persist chat drafts with 500ms debounce
…r-rate-limit-utility-module

test(lib): add unit tests for rateLimit utility
fix(contract): prevent ReceiptIndex from using persistent storage for…
Lynndabel and others added 26 commits April 25, 2026 20:56
…ontrast

feat(frontend): add accessible contrast to transaction filter chips
…t#521 leojay-net#522

feat(frontend): add auto-scroll behavior to TransactionAmountDisplay (leojay-net#522)
- Attach a containerRef to the wrapper div
- useEffect scrolls the element into view (smooth, nearest) whenever
  displayText changes, keeping the latest amount visible without manual
  scrolling
- Add two new unit tests: scroll on mount and scroll on displayText change

feat(frontend): add accessible color contrast telemetry to chatTelemetry (leojay-net#521)
- Add avatar_color_check to ChatEventName union
- Expose chatTelemetry.avatarColorCheck() public method that emits the
  new event with the payload enriched by withAccessibleAvatarContrast
  (contrast ratio, compliant flag, accessible text color)
- Add four unit tests covering compliant dark/light backgrounds, consent
  guard, and enriched payload shape

fix(frontend): resolve race condition in CCIPBridgeModal (leojay-net#520)
- Introduce transactionHashRef kept in sync with transactionHash state so
  pollTransferStatus always reads the latest hash without closing over a
  stale value
- Pass an abort signal object into each poll invocation; cleanup sets
  signal.aborted = true so in-flight async calls cannot mutate state after
  the modal closes or the effect re-runs
- Add two regression tests: no state update after modal closes mid-poll,
  and stale slow response does not overwrite a faster terminal response

docs: improve inline documentation for timelock role check (leojay-net#519)
- Add full JSDoc to queue_admin_action explaining the admin role check,
  timelock enforcement, arguments, return value, and error variants
- Add full JSDoc to execute_admin_action covering the role check rationale,
  off-by-one boundary semantics, arguments, and error variants
- Expand set_operator docs with a dedicated 'Role separation (timelock
  role check)' section explaining why admin/operator must stay separate,
  the two boundary checks (fix leojay-net#525), and all error variants

Closes leojay-net#519
Closes leojay-net#520
Closes leojay-net#521
Closes leojay-net#522
- Add integration test for MigrationCheckEvent emission in validate_withdrawal_quota
- Test verifies event is emitted when storage_version < ESCROW_STORAGE_VERSION
- Closes leojay-net#510
…ch-withdrawal

feat(contract): implement migration check for validate_withdrawal_quota
- Add Cmd/Ctrl+N for new chat
- Add Cmd/Ctrl+H for open history
- Add Cmd/Ctrl+B for open bridge modal
- Add Cmd/Ctrl+Shift+C for cancel request
- Add comprehensive unit tests for all keyboard shortcuts
- Ensure no regressions in existing functionality

Closes leojay-net#561
…rd-shortcuts

feat(frontend): add keyboard shortcuts to ChatInput.tsx
- Add smooth modal entrance/exit animations with backdrop blur
- Implement step-by-step slide transitions between form steps
- Add animated loading states, error messages, and success indicators
- Include beneficiary dropdown and save prompt animations
- Animate transfer timeline and status updates
- Use AnimatePresence for proper animation lifecycle management

Issue: leojay-net#556
…ortcuts

Feat/556 add framer-motion animation
…-527-multi-issue

fix(frontend): resolve race condition in useChat.ts (leojay-net#530)
…work-status-toast

feat(frontend): add network status toast to AuditTable
- Add detailed Rustdoc comments for set_limit_max_cap, get_set_limit_max_cap, and SetLimitMaxCapEvent
- Clarify that the global cap prevents future set_limit calls from exceeding the ceiling
- Note that existing token limits are not retroactively reduced
- Update FIAT_BRIDGE_README.md to include the new admin functions
- Improve DataKey::SetLimitMaxCap documentation

Closes leojay-net#552
…-limit-docs

docs: improve inline documentation for maximum cap limit
@kongwen686

Copy link
Copy Markdown
Author

Payment note for this bounty if the PR is accepted: I cannot currently receive Stripe payouts from mainland China. Preferred payout is PayPal: hooqee@126.com. Alternate contact: chaoqiang.tian@gmail.com. If blockchain payout is supported, EVM: 0x225b4bC64E051827c069312f82fA590Ec9632209, Stellar: GDYPL56JCCHD75ZB2I5Z4FT4WEWZFRD24LEC62XQ2MBL34653XKO65LA. If Alipay is supported: chaoqiang457963@126.com.

@kongwen686

Copy link
Copy Markdown
Author

CI note: I checked the failing jobs on this PR. The local validation for this change passes (npm run test:unit -- src/components/__tests__/CCIPBridgeModal.test.tsx, npm run typecheck, and Prettier check).

The GitHub Actions failures appear unrelated to this PR diff:

  • Frontend CI fails during npm run build on pre-existing lint/type issues in untouched files including BankDetailsModal.tsx, ReceiptDrawer.test.tsx, StellarFiatModal.tsx, TransactionAmountDisplay.tsx, several existing tests, and networkQueue.ts.
  • Contract Tests fail in stellar-contracts clippy with existing warnings promoted to errors, including deprecated env.events().publish, unused imports, len() > 0, and lifetime syntax warnings.

This PR only changes CCIPBridgeModal.tsx and CCIPBridgeModal.test.tsx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(frontend): add ARIA accessibility labels to CCIPBridgeModal.tsx