You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @dkuaf , there is already #1671 that addresses this issue.
In my PR I made the fewest possible changes in order to address the issue.
Maybe I can merge my PR with your changes too, since it seems they makes sense.
I usually hesitate to make too many changes and prefer to wait for maintainers reaction on first impl.
Drop a comment there if you like.
Hi @dkuaf , there is already #1671 that addresses this issue. In my PR I made the fewest possible changes in order to address the issue. Maybe I can merge my PR with your changes too, since it seems they makes sense. I usually hesitate to make too many changes and prefer to wait for maintainers reaction on first impl. Drop a comment there if you like.
sorry i did not know that issue had an pr, i did not see a link on the issue to an open PR
i am closing this (i think nullable change make sense)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nullable check for titlebarbutton
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
nullref exception when TitleBar.Visibilty = Collapsed
Issue Number: #1670
fixes #1670
What is the new behavior?
early return on null
Other information
n/a