Skip to content

document rsa private params not validated #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lestrrat merged 1 commit into from
Jun 18, 2026
+7 −0
Merged

document rsa private params not validated #2217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions jwk/rsa.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,13 @@ func validateRSAKey(key interface {
return err
}
if checkPrivate {
// For private keys we only require a non-empty "d". We intentionally do
// NOT validate p, q, the CRT values, primality, n == p*q, or e*d ≡ 1
// (mod λ(n)) here: RFC 7517/7518 do not mandate such parse-time checks and
// they are expensive. A malformed private key is caught by crypto/rsa's own
// consistency checks (p*q == n, d*e ≡ 1) the moment it is used to sign or
// decrypt, and the public thumbprint/export uses only n and e (validated
// just above). Do not add full RSA private-parameter validation here.
if priv, ok := key.(keyWithD); ok {
if d, ok := priv.D(); !ok || len(d) == 0 {
return fmt.Errorf(`missing "d" value`)
Expand Down
Loading