blocks: implements objects.Block#66
Open
zchee wants to merge 4 commits into
Open
Conversation
da4c11a to
0e57e67
Compare
Collaborator
|
Contributor
Author
|
@lestrrat Thanks for advice. will fix and implements more structs. |
Contributor
Author
|
@lestrrat I have almost implemented the Slack block feature. but uses |
Collaborator
|
One thing that might be good to have: an actual consumer code of your data objects. For example, how do you actually create/consume Block elements? This will tell you if it's a good idea to use interfaces and/or if you have the adequate methods to properly use them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
objects.Block.The
Blockinterface impl might be ugly, pls advice how to implements it 🙏TODO:
[]interfacefield