chore: exclude changelog and lockfiles from cubic reviews - #1080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We hit 99% of cubic's monthly reviewed-line quota. The biggest waste: every PR touches
CHANGELOG.md(and rebases trigger incremental re-reviews of it), and lockfiles occasionally ride along in dependency bumps.What
Adds
reviews.ignore.filestocubic.yaml(per the repository config schema) so cubic skips:CHANGELOG.mduv.lockfrontend/package-lock.jsonEverything else in the config (custom agents, ultrareview patterns) is untouched.
Why it's safe
None of these files carry reviewable logic: changelog entries are prose, and the lockfiles are generated artifacts. The source manifests (
pyproject.toml,frontend/package.json) remain reviewed.