Skip to content

chore(release): rc-stack pulls the pushed image + optional --with-runtimes - #1133

Merged
lfnovo merged 1 commit into
mainfrom
chore/release-tooling-retro-v1.13.0
Jul 14, 2026
Merged

chore(release): rc-stack pulls the pushed image + optional --with-runtimes#1133
lfnovo merged 1 commit into
mainfrom
chore/release-tooling-retro-v1.13.0

Conversation

@lfnovo

@lfnovo lfnovo commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Summary

Release-process tooling improvements captured in the v1.13.0 retro. No user-facing change (release scripts + process doc only).

  • rc-stack.sh up docker-pulls the pushed tag by default — a same-named docker-build-local image can otherwise shadow the registry artifact, so Phase 6 could verify the wrong image. Non-fatal for local-only tags (warns and uses the local image).
  • New --with-runtimes flag — enables the opt-in heavy engines (Docling + Crawl4AI) on the RC stack (RC_ENABLE_DOCLING/RC_ENABLE_CRAWL4AI), so the published image's opt-in install path can be exercised with real data. The release-test compose defaults these to empty, so fresh/upgrade image-gate tests stay fast.
  • Documented two gotchas in RELEASE_PROCESS.md: local-tag shadowing, and judging opt-in gating on a clean image rather than a dev venv that may have the runtimes installed out-of-band (which reports them available and misleadingly enables the engines).

Why

During the v1.13.0 release, verifying the opt-in runtimes on the published image required a manual compose override, and the local build had to be docker pulled away first to avoid testing the wrong artifact. These changes fold both into the tooling.

Testing

  • bash -n scripts/release-test/rc-stack.sh clean; flag-parsing and ${WITH_RUNTIMES:+true} env mapping verified (dump positional still parses; flag can appear anywhere after the tag).
  • Compose interpolation defaults (${RC_ENABLE_*:-}) leave fresh/upgrade tests unchanged (empty → the entrypoint's is_true is false → no install).

🤖 Generated with Claude Code

Review in cubic

…times

Retro improvements from the v1.13.0 release:
- rc-stack.sh 'up' now docker-pulls lfnovo/open_notebook:<tag> by default so a
  same-named local build can't shadow the registry artifact during Phase 6
  verification (non-fatal for local-only tags).
- New --with-runtimes flag enables the opt-in heavy engines (Docling +
  Crawl4AI) on the RC stack via RC_ENABLE_DOCLING/RC_ENABLE_CRAWL4AI, so the
  published image's opt-in install path can be exercised with real data. The
  release-test compose defaults these empty, keeping fresh/upgrade tests fast.
- Documented both gotchas (local-tag shadowing; judging opt-in gating on a
  clean image vs a dev venv with runtimes installed out-of-band) in
  RELEASE_PROCESS.md.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@lfnovo
lfnovo merged commit 2181b14 into main Jul 14, 2026
12 checks passed
@lfnovo
lfnovo deleted the chore/release-tooling-retro-v1.13.0 branch July 14, 2026 10:29
lfnovo added a commit that referenced this pull request Jul 20, 2026
The release audit (git log v1.13.0..main) found 27 merged commits but
only 11 represented in [Unreleased]. Adds the 14 missing entries and
corrects two existing problems:

- The #1137 entry (per-transformation model selection) was filed under
  [1.13.0], but its commit is not in the v1.13.0 tag — v1.13.0 shipped a
  changelog entry for an unshipped fix. Moved verbatim to [Unreleased].
- The anthropic_compatible entry was a one-line stub with no issue
  reference; rewritten in house style and pointed at #675.

New entries cover the DNS-pinning hardening (#1063), worker concurrency
(#893), episode max_tokens in the UI (#991), error-text capping (#1136),
the IME/chat composer perf fix (#1147), the anthropic shim removal
(#1055), the esperanto floor bump (#1176), ja-JP translation quality
(#998), i18n placeholder parity (#1159), the OLLAMA_API_BASE docs fix
(#1148), and the CI/tooling chores (#1134, #940, #1133, #1158).

A ### Changed section was added; every commit in the range is now
represented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant