fix: update Google/Vertex connection test model to gemini-2.5-flash - #996
fix: update Google/Vertex connection test model to gemini-2.5-flash#996pelazas wants to merge 1 commit into
Conversation
The connection test hardcoded gemini-2.0-flash, which Google has retired, so testing a valid Google AI key failed with 404 NOT_FOUND. Fixes lfnovo#970 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Several IDs the PR introduced don't exist or are near shutdown, verified against Google's official model/deprecation pages (2026-07): - connection test model gemini-2.5-flash -> gemini-3.5-flash (2.5-flash retires 2026-10-16; 3.5-flash is the current stable GA and Google's named replacement, so the lfnovo#970 fix doesn't re-break in ~3 months) - gemini-3.5-pro (does not exist) -> gemini-2.5-pro in docs - plain gemini-3.1-flash (not a GA Gemini-API id) dropped from the Vertex discovery list / preferences / docs; use gemini-3.5-flash or -flash-lite - dead gemini-pro dropped from preferences and docs Ported lfnovo#996's lfnovo#970 regression test, pinned to gemini-3.5-flash.
* fix: update Google model version in connection tester and tests * fix: updated the gemini model lists that references deprecated models * fix: update also documentation. This is more prone to not follow the maintainer's directives, so PTADL * fix: forgot two references to gemini deprecated versions * fix: use valid, longer-lived gemini model IDs Several IDs the PR introduced don't exist or are near shutdown, verified against Google's official model/deprecation pages (2026-07): - connection test model gemini-2.5-flash -> gemini-3.5-flash (2.5-flash retires 2026-10-16; 3.5-flash is the current stable GA and Google's named replacement, so the #970 fix doesn't re-break in ~3 months) - gemini-3.5-pro (does not exist) -> gemini-2.5-pro in docs - plain gemini-3.1-flash (not a GA Gemini-API id) dropped from the Vertex discovery list / preferences / docs; use gemini-3.5-flash or -flash-lite - dead gemini-pro dropped from preferences and docs Ported #996's #970 regression test, pinned to gemini-3.5-flash. --------- Co-authored-by: Luis Novo <lfnovo@gmail.com>
|
Closing as a duplicate — the broader cleanup in #1027 (just merged) subsumes this, and it credits your PR. Thank you for catching the root issue (#970) first and for the regression test; I ported exactly that test into #1027, pinned to gemini-3.5-flash rather than gemini-2.5-flash. Heads-up for context: gemini-2.5-flash (which this PR used) is already scheduled for shutdown on 2026-10-16, so it would have re-broken the connection test in ~3 months — gemini-3.5-flash is the current stable GA and Google's named replacement. Appreciate the fix! |
|
Follow-up for context: #1035 addresses the root cause you first flagged in #970. Rather than tracking Google's model ids (each has a hard-shutdown date, so it's a treadmill), it switches the Google/Vertex test to Google's floating |
Description
Testing a perfectly valid Google AI key on the Manage Models page fails with a 404, because the connection test calls
gemini-2.0-flash— which Google has retired. Same for the Vertex entry.This swaps both
TEST_MODELSentries togemini-2.5-flash, as suggested in the issue thread. Also updated the staleTEST_MODELSsnippet inopen_notebook/ai/CLAUDE.mdso the docs match the code.Left alone on purpose: the static
VERTEX_MODELSdiscovery list inapi/credentials_service.pyalso carries some older model names, but that's model discovery, not the connection test — happy to do a follow-up if you want it refreshed too.Related Issue
Fixes #970
Type of Change
How Has This Been Tested?
uv run pytest)Test Details:
Added a regression test in
tests/test_credentials_api.pypinning the google/vertex test models togemini-2.5-flash(it fails onmain, passes here). Full suite: 223 passed.ruff checkclean. I didn't run a live key test against Google's API, but the change is exactly the model swap suggested by @lfnovo in the issue.Design Alignment
Which design principles does this PR support? (See DESIGN_PRINCIPLES.md)
Explanation:
Keeps the Google/Vertex provider path actually usable — a key test that always fails defeats the point of supporting the provider.
Checklist
Code Quality
Testing
make rufforruff check . --fixmake lintoruv run python -m mypy .(mypy isn't in the dev deps of my env; change is a string-literal swap)Documentation
/docs(if applicable) — updated theTEST_MODELSsnippet inopen_notebook/ai/CLAUDE.mdDatabase Changes
/migrations)Breaking Changes
Screenshots (if applicable)
N/A
Additional Context
The issue is labeled
ready+good first issueand had been quiet for a bit, so I picked it up — hope that's fine. Happy to adjust if you'd rather use a different model name.Pre-Submission Verification
ready, but not formally assigned — see Additional Context)