Merged
Conversation
Our Gsym inline frame parsing logic contains two error strings that contain formatting identifiers but never actually format anything. Fix that. Signed-off-by: Daniel Müller <deso@posteo.net>
d-e-s-o
force-pushed
the
topic/gsym-errs
branch
from
b9a0200 to
3829f2d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1553 +/- ##
==========================================
+ Coverage 95.40% 95.56% +0.15%
==========================================
Files 56 56
Lines 9551 9551
==========================================
+ Hits 9112 9127 +15
+ Misses 439 424 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our Gsym inline frame parsing logic contains an error string that contains formatting identifiers but never formats anything. Fix that.