fix: propagate progress events and events before async work#3445
Merged
fix: propagate progress events and events before async work#3445
Conversation
Fixes two bugs with the Queue class: 1. When joining an existing job, progress events were not received by the second context 2. If a progress event was emitted before any async work was done in a queue job under the concurrency threshold, it was missed because the job result recipient had not been registered yet
achingbrain
force-pushed
the
fix/queue-progress-events
branch
from
abaa93a to
7571e5f
Compare
achingbrain
changed the title
3 tasks
achingbrain
changed the title
tabcat
reviewed
Apr 10, 2026
tabcat
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two bugs with the Queue class:
Change checklist