Skip to content

Mark unrelated parsing error as warning #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
photovoltex merged 3 commits into from
May 3, 2025
Merged

Mark unrelated parsing error as warning #1491

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af5444f
mark known parsing error as warning
photovoltex Apr 22, 2025
4c34c70
add copilot suggestion
photovoltex Apr 22, 2025
474f126
adjust unknown enum handling for json
photovoltex May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions connect/src/spirc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,12 +411,16 @@ impl SpircTask {
}
}
};
( $next:expr, match |$ok:ident| $use_ok:expr ) => {
( $next:expr, $log:ident!($msg:expr), match |$ok:ident| $use_ok:expr ) => {
unwrap!($next, |$ok| match $ok {
Ok($ok) => $use_ok,
Err(why) => error!("could not parse {}: {}", stringify!($ok), why),
Err(why) => $log!("{} could not parse {}: {}", $msg, stringify!($ok), why),
})
};

( $next:expr, match |$ok:ident| $use_ok:expr ) => {
unwrap! { $next, error!(""), match |$ok| $use_ok }
};
Comment thread
photovoltex marked this conversation as resolved.
Outdated
}

if let Err(why) = self.session.dealer().start().await {
Expand Down Expand Up @@ -486,6 +490,7 @@ impl SpircTask {
},
session_update = self.session_update.next() => unwrap! {
session_update,
warn!("Known parsing error for WIFI_BROADCAST_CHANGED."),
match |session_update| self.handle_session_update(session_update)
},
cmd = async { commands?.recv().await }, if commands.is_some() => if let Some(cmd) = cmd {
Expand Down