HarmonyOS/OpenHarmony Port#13152
Conversation
|
@slouken Request for review |
|
Can you please rebase on top of current master and remove all commits which you did not author? git fetch https://github.com/libsdl-org/SDL main
git rebase -i FETCH_HEAD
<remove all commits which you did not author. In vim, "dd" removes the current line, "<ESC>:wq" saves and exits)>
git push git@github.com:Jack253-png/SDL HEAD:OpenMinecraft-Dev -f |
|
Seeing you implemented vulkan support, does SDL_gpu work? Do the SDL_gpu_examples work? |
I will test later, because I don't have test platform, I need to find other people to do this. |
The previous implementation processed all touch points in the array for every touch event, which could cause duplicate or incorrect events since the array contains the current state of all fingers. Now we correctly identify and process only the finger that triggered the current event (touchEvent.id), improving touch event accuracy on OpenHarmony platforms.
OHOS: Fix touch event processing to only handle the triggering finger
|
我在鸿蒙笔记本上使用cmake 目前编译会报错，暂时无法提供报错信息，我在华为店的笔记本上尝试的 |
你在自己的deveco studio上试试（ |
| if(TARGET SDL3-shared) | ||
| target_link_options(SDL3-shared PRIVATE "-Wl,-z,max-page-size=16384") | ||
| target_link_options(SDL3-shared PRIVATE "-Wl,-z,common-page-size=16384") | ||
| endif() |
There was a problem hiding this comment.
Why are these not in the elseif(OHOS) case below?
There was a problem hiding this comment.
These configs are not for ohos
There was a problem hiding this comment.
A bad merge then? Because you are adding those lines to the android case.
| @@ -0,0 +1,21 @@ | |||
| # the minimum version of CMake. | |||
| cmake_minimum_required(VERSION 3.5.0) | |||
There was a problem hiding this comment.
This should read cmake_minimum_required(VERSION 3.5...4.0) in order to avoid cmake deprecation warnings.
There was a problem hiding this comment.
HarmonyOS toolchain provides a old version of cmake, so I have to do this
There was a problem hiding this comment.
The ...4.0 part will not force you to use a newer cmake: https://cmake.org/cmake/help/v4.0/command/cmake_minimum_required.html
8 participants
Description
SDL support for harmonyos
Existing Issue(s)
#9837