Detect the best pixel format for intermediate scaled surfaces.#15574
Open
ccawley2011 wants to merge 2 commits into
Open
Detect the best pixel format for intermediate scaled surfaces.#15574ccawley2011 wants to merge 2 commits into
ccawley2011 wants to merge 2 commits into
Conversation
ccawley2011
commented
May 13, 2026
slouken
reviewed
May 13, 2026
| default: | ||
| break; | ||
| } | ||
| // Try and find an alpha format with the same layout. |
Collaborator
There was a problem hiding this comment.
Your code changes here are not equivalent. For example, I don't think SDL_PIXELFORMAT_ABGR1555 is going to add SDL_PIXELFORMAT_XBGR1555, or am I missing something?
Contributor
Author
There was a problem hiding this comment.
This was intentional since I'm not sure there's a use case for it - in general, you'd want to always use the screen format (since that can be used with SDL_BlitCopy) unless you need an alpha channel. If needed, I can split that change into a separate commit.
slouken
reviewed
May 13, 2026
Collaborator
|
This change seems fine in theory, but the changes are risky. I already noted a few issues above. You should re-review your changes after a day or so and this should not be backported to 3.4.x. |
ccawley2011
force-pushed
the
promote-scale-format
branch
from
d3297b1 to
73430ae
Compare
slouken
reviewed
May 13, 2026
slouken
reviewed
May 13, 2026
ccawley2011
force-pushed
the
promote-scale-format
branch
from
73430ae to
de191c8
Compare
ccawley2011
force-pushed
the
promote-scale-format
branch
from
de191c8 to
477ed72
Compare
Collaborator
|
Is this re-reviewed and ready to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This generalises some of the logic from the software renderer so that it can be used elsewhere - this increases the likelihood of using the optimised conversion routines when using a 16-bit BGR format.