Fix JoyCon triggers on the web#15816
Open
Nintorch wants to merge 1 commit into
Open
Conversation
Collaborator
|
This PR assumes that any controller with two axes will have trigger buttons, but that's not necessarily the case. I haven't tried it, but I can imagine an SNES controller falling into this code path. Do you have any other way of positively identifying this case? |
Contributor
Author
|
Hm, would it be acceptable to always have at least 6 axes and always read the trigger values from the buttons in case the mapping is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes JoyCon controller triggers detection in case they're in mini gamepad mode.
Previously they weren't detected because the browser reported having 2 real axes, while the SDL code expected to have at least 4.
The triggers still don't work correctly in Firefox, because they're detected as d-pad inputs, so I think that's a bug in the browser itself.
Existing Issue(s)
None