Add flexible Emscripten joystick mapping#15823
Open
Nintorch wants to merge 1 commit into
Open
Conversation
49579ff to
296f0cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new flexible gamepad mapping by using the
JoystickGetGamepadMappingfunction.By "flexible" here I mean that the mapping automatically adapts to the controller's button count, by providing additional misc SDL buttons for non-standard buttons if necessary. This allows the mapping to recognize the PS4/PS5 touchpad button and, for example, JoyCon pair SL/SR buttons.
This code doesn't check if the controller has a standard button mapping from the browser to preserve the previous behavior.
This PR also documents the rules for gamepad mappings for the Emscripten backend that I propose (they can be changed if necessary):
"usb gamepad")This PR was tested in Chromium (Microsoft Edge) and Firefox, everything seems to work as expected (the only problem is that Firefox doesn't recognize JoyCon controllers for me, but that's a different problem)
See also the discussion at #15819 (comment)
Existing Issue(s)
None