Add normalized names for Emscripten joysticks#15824
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR normalizes the joystick names for the Emscripten joystick backend (i.e. removes the vendor/product IDs from the name, because they can be retrieved from the GUID). Here's a table that shows the current and new names:
usb gamepad (Vendor: 0810 Product: e501)usb gamepad0810-e501-usb gamepadusb gamepadXbox 360 Wireless ControllerXbox 360 Wireless ControllerXbox 360 Wireless ControllerXbox 360 Wireless ControllerWireless Controller (STANDARD GAMEPAD Vendor: 054c Product: 09cWireless Controller054c-09cc-Wireless ControllerWireless ControllerXbox One S ControllerXbox One S ControllerXbox 360 Wireless ControllerXbox 360 Wireless ControllerWireless Gamepad (STANDARD GAMEPAD Vendor: 057e Product: 2006)Wireless GamepadWireless Gamepad (STANDARD GAMEPAD Vendor: 057e Product: 2007)Wireless GamepadJoy-Con L+R (STANDARD GAMEPAD Vendor: 057e Product: 200e)Joy-Con L+RWould this be a good idea?
Existing Issue(s)
None