Don't use SDL filesystem in DInput joystick driver#15845
Open
Nintorch wants to merge 1 commit into
Open
Conversation
5 tasks
slouken
reviewed
Jun 17, 2026
| char path[128]; | ||
| WIN32_FIND_DATAA file; | ||
| SDL_snprintf(path, sizeof(path), "%s%s", directories[i], "/EZFRD64.DLL"); | ||
| HANDLE search_handle = FindFirstFileA(path, &file); |
Collaborator
There was a problem hiding this comment.
I don't mind switching to Win32 filesystem code here, but this isn't equivalent, and won't find e.g. "C:\Windows\USB_Vibration\791847\EZFRD64.DLL"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the DirectInput joystick driver optionally not use the SDL filesystem subsystem in case an external project that intergrates SDL (e.g. Godot Engine) doesn't use its filesystem subsystem.
Please let me know if this change is acceptable!
Existing Issue(s)
None