Skip to content

Fix Regression on profile screen. #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veloce merged 1 commit into from
Nov 4, 2025
Merged

Fix Regression on profile screen. #2339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions lib/src/model/user/user_repository_providers.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,25 +18,11 @@ Future<User> user(Ref ref, {required UserId id}) {
return ref.read(userRepositoryProvider).getUser(id, withCanChallenge: true);
}

@riverpod
Future<(User, UserStatus)> userAndStatus(Ref ref, {required UserId id}) {
final repo = ref.read(userRepositoryProvider);
return Future.wait([
repo.getUser(id, withCanChallenge: true),
repo.getUsersStatuses({id}.lock),
], eagerError: true).then((value) => (value[0] as User, (value[1] as IList<UserStatus>).first));
}

@riverpod
Future<UserPerfStats> userPerfStats(Ref ref, {required UserId id, required Perf perf}) {
return ref.read(userRepositoryProvider).getPerfStats(id, perf);
}

@riverpod
Future<IList<UserStatus>> userStatuses(Ref ref, {required ISet<UserId> ids}) {
return ref.read(userRepositoryProvider).getUsersStatuses(ids);
}

@riverpod
Future<IList<Streamer>> liveStreamers(Ref ref) {
return ref.withAggregatorCacheFor(
Expand Down
7 changes: 2 additions & 5 deletions lib/src/view/user/user_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import 'package:lichess_mobile/src/model/game/game_filter.dart';
import 'package:lichess_mobile/src/model/relation/relation_repository.dart';
import 'package:lichess_mobile/src/model/user/user.dart';
import 'package:lichess_mobile/src/model/user/user_repository.dart';
import 'package:lichess_mobile/src/model/user/user_repository_providers.dart';
import 'package:lichess_mobile/src/network/connectivity.dart';
import 'package:lichess_mobile/src/network/http.dart';
import 'package:lichess_mobile/src/styles/lichess_icons.dart';
Expand Down Expand Up @@ -125,7 +124,7 @@ class _UserScreenState extends ConsumerState<UserScreen> {
);
}
return FullScreenRetryRequest(
onRetry: () => ref.invalidate(userProvider(id: widget.user.id)),
onRetry: () => ref.invalidate(_userScreenDataProvider(widget.user.id)),
);
},
),
Expand Down Expand Up @@ -166,9 +165,7 @@ class _UserProfileListView extends ConsumerWidget {
Future<void> userAction(Future<void> Function(LichessClient client) action) async {
setIsLoading(true);
try {
await ref
.withClient(action)
.then((_) => ref.invalidate(userAndStatusProvider(id: user.id)));
await ref.withClient(action).then((_) => ref.invalidate(_userScreenDataProvider(user.id)));
} finally {
setIsLoading(false);
}
Expand Down