Add notification broadcast game notifications for following a FIDE player#3297
Draft
julien4215 wants to merge 1 commit into
Draft
Add notification broadcast game notifications for following a FIDE player#3297julien4215 wants to merge 1 commit into
julien4215 wants to merge 1 commit into
Conversation
game in a broadcast
julien4215
force-pushed
the
broadcast-notif
branch
from
6ea4ff3 to
6151c2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send a notification to the user when a FIDE player he follows begin a game in a broadcast.
I have added a parameter to the BroadcastAnalysisController so that when the user taps the notification it opens with the pov of the player he follows. Because the controller is used in a lot of places in the code it requires passing the param in each widget. I wonder if there is another way to achieve this.
It will require lichess-org/lila#20627