[WIP] feat: read PDG gindex getters from either contract layout - #300
Open
DiRaiks wants to merge 1 commit into
Open
[WIP] feat: read PDG gindex getters from either contract layout#300DiRaiks wants to merge 1 commit into
DiRaiks wants to merge 1 commit into
Conversation
PDG renames GI_FIRST_VALIDATOR_PREV/CURR to GI_FIRST_VALIDATOR_PRE_GLOAS and GI_VALIDATORS when redeployed for Gloas. One vendored ABI serves mainnet and hoodi, which are upgraded at different times, so read whichever pair the deployment exposes and fail with both names listed when neither answers. Make the hoodi gindex pins layout-aware.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PDG renames GI_FIRST_VALIDATOR_PREV/CURR to GI_FIRST_VALIDATOR_PRE_GLOAS and GI_VALIDATORS when redeployed for Gloas. One vendored ABI serves mainnet and hoodi, which are upgraded at different times, so read whichever pair the deployment exposes and fail with both names listed when neither answers. Make the hoodi gindex pins layout-aware.
Demo
Code review notes
Testing notes
Checklist: