[TS] LPS-201682 Error Message is copied over between Form Fields by IstvanD · Pull Request #2400 · liferay-forms/liferay-portal

IstvanD · 2023-11-24T11:42:30Z

Dear Team,

Could you please review this pull request?

Thank you and best regards,
István

Related issue: https://liferay.atlassian.net/browse/LPS-201682

liferay-continuous-integration · 2023-11-24T11:42:34Z

CI is automatically triggering the following test suites:

ci:test:sf

liferay-continuous-integration · 2023-11-24T11:47:01Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: c1206b917ad645129beaaebf7186bac2091a8648

Sender Branch:

Branch Name: LPS-201682
Branch GIT ID: 07febda3324ccc52c7a09d501b2f72b8f0ec0363

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2023-11-24T11:50:07Z

Jenkins Build:test-portal-source-format#2281

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-forms#2400

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - IstvanD > liferay-forms - PR#2400 - 2023-11-24[03:42:45]

Testray Importer:publish-testray-report#9631

marcelabc · 2023-11-24T12:02:00Z

ci:test:relevant

marcelabc · 2023-11-24T12:02:26Z

ci:test:forms

marcelabc · 2023-11-24T13:35:35Z

ci:stop

liferay-continuous-integration · 2023-11-24T13:38:24Z

❌ ci:test:forms - 157 out of 176 jobs passed in 1 hour 33 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1347401_5320

Base Branch:

Branch Name: master
Branch GIT ID: a326f83a03da704d0f73d021af1dccf219fc2b63

Upstream Comparison:

Branch GIT ID: 82d959e5d37f7cf326fb8c17a5a7b7d1a6713ba5
Jenkins Build URL: EE Development Acceptance (master) - 190 - 2023-11-23[16:39:30]

ci:test:forms - 157 out of 176 jobs PASSED

19 Failed Jobs:

157 Successful Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2023-11-24T13:39:44Z

						<h1>Unable to generate test report.</h1><p>Jenkins encountered the following error while generating test report:</p><pre><code>Sourced file: inline evaluation of: `` 						 							import com.liferay.jenkins.results.parser.Build; 							import co . . . '' : TargetError : at Line: 86 : in file: inline evaluation of: `` 						 							import com.liferay.jenkins.results.parser.Build; 							import co . . . '' : throw e ;

Target exception: java.lang.NullPointerException

Base Branch:

Branch Name: master

Branch GIT ID: a326f83a03da704d0f73d021af1dccf219fc2b63

Job Summary:

Job Link: test-portal-acceptance-pullrequest(master)

For more details click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2023-11-24T13:42:09Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#5320

Jenkins Report:jenkins-report.html

Jenkins Suite:forms

Pull Request:liferay-forms#2400

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:forms - IstvanD > liferay-forms - PR#2400 - 2023-11-24[04:02:38]

Testray Importer:publish-testray-report#21728

liferay-continuous-integration · 2023-11-24T13:44:41Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#12080

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-forms#2400

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - IstvanD > liferay-forms - PR#2400 - 2023-11-24[04:02:10]

Testray Importer:publish-testray-report#27829

alinedoleron

Hi @IstvanD. I have one comment.

alinedoleron · 2023-11-24T15:09:41Z

+const requireUpdatePageFieldNames = [
+	'autocomplete',
+	'inputMask',
+	'numericInputMask',
+	'options',
+	'requireConfirmation',
+	'required',
+	'validation',
+];


Hi @IstvanD. According to the previous ci tests I ran on the initial PR, some tests have failed. I fixed most of them and I hope I have covered the main ones.

So please, add the following missing fields:

Suggested change

const requireUpdatePageFieldNames = [

'autocomplete',

'inputMask',

'numericInputMask',

'options',

'requireConfirmation',

'required',

'validation',

];

const requireUpdatePageFieldNames = [

'alphabeticalOrder',

'autocomplete',

'dataSourceType',

'ddmDataProviderInstanceId',

'expirationDate',

'hideField',

'inputMask',

'limitToOneSubmissionPerUser',

'multiple',

'neverExpire',

'numericInputMask',

'options',

'predefinedValue',

'requireConfirmation',

'required',

'sendEmailNotification',

'validation',

];

Sorry for the inconvenience.
Regards,

hi @alinedoleron thank you for your feedback. I have added the missing fields.
537b54f

alinedoleron · 2023-11-24T15:50:50Z

ci:test:relevant

alinedoleron · 2023-11-24T15:51:21Z

ci:test:forms

alinedoleron · 2023-11-24T15:51:29Z

ci:test:data-engine

liferay-continuous-integration · 2023-11-24T18:00:28Z

❌ ci:test:forms - 0 out of 1 jobs passed in 2 hours 8 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: fe42dcf78ea98f6a14256bc733c20460b2bf6f89

Upstream Comparison:

Branch GIT ID: a326f83a03da704d0f73d021af1dccf219fc2b63
Jenkins Build URL: EE Development Acceptance (master) - 192 - 2023-11-24[04:40:22]

ci:test:forms - 0 out of 1 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

0 Jobs Passed.
1 Job Failed.

A CI failure has occurred. QA Engineering has been notified. Please try again later or contact QA Engineering for an update.

For upstream results, click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2023-11-24T18:02:25Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#12085

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-forms#2400

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - IstvanD > liferay-forms - PR#2400 - 2023-11-24[07:51:03]

Testray Importer:publish-testray-report#27849

liferay-continuous-integration · 2023-11-24T18:05:04Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#12086

Jenkins Report:jenkins-report.html

Jenkins Suite:forms

Pull Request:liferay-forms#2400

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:forms - IstvanD > liferay-forms - PR#2400 - 2023-11-24[07:51:33]

Testray Importer:publish-testray-report#27850

alinedoleron · 2023-11-24T18:07:44Z

ci:test:forms

liferay-continuous-integration · 2023-11-24T20:56:00Z

❌ ci:test:forms - 170 out of 176 jobs passed in 1 hour 54 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b6372d50d395b7ea8a6646046de25496444263c3

Upstream Comparison:

Branch GIT ID: fe42dcf78ea98f6a14256bc733c20460b2bf6f89
Jenkins Build URL: EE Development Acceptance (master) - 193 - 2023-11-24[08:41:41]

ci:test:forms - 170 out of 176 jobs PASSED

6 Failed Jobs:

170 Successful Jobs:

For more details click here.

Failures unique to this pull:

Failures in common with acceptance upstream results at fe42dcf:

functional-tomcat90-mysql57-jdk8/1/18
1. LocalFile.FormsFieldsets#PreserveTheMultipleSelectionsProperty - Poshi Report - Poshi Summary - Poshi Console - Console Output

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2023-11-24T21:01:23Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#4952

Jenkins Report:jenkins-report.html

Jenkins Suite:forms

Pull Request:liferay-forms#2400

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:forms - IstvanD > liferay-forms - PR#2400 - 2023-11-24[11:00:18]

Testray Importer:publish-testray-report#10770

marcelabc · 2023-11-27T11:28:09Z

Failures not related 👍

marcelabc · 2023-11-27T11:28:14Z

ci:forward:force

liferay-continuous-integration · 2023-11-27T11:28:18Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf
ci:test:stable

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites complete:

ci:test:relevant
ci:test:sf
AND If the following test suites pass:
ci:test:stable

liferay-continuous-integration · 2023-11-27T11:28:19Z

Skipping previously completed test suites:

ci:test:relevant
AND Skipping previously passed test suites:
ci:test:stable

liferay-continuous-integration · 2023-11-27T11:32:10Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e9c93faeaa8c3ad54b80f37da4c5d816bb0c9d4f

Sender Branch:

Branch Name: LPS-201682
Branch GIT ID: 537b54f88435b5bfa91a614e6af4225852a4c730

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2023-11-27T11:34:31Z

Jenkins Build:test-portal-source-format#4729

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-forms#2400

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - IstvanD > liferay-forms - PR#2400 - 2023-11-27[03:28:24]

Testray Importer:publish-testray-report#17520

marcelabc · 2023-11-27T12:02:50Z

ci:forward:force

liferay-continuous-integration · 2023-11-27T12:02:55Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf
ci:test:stable

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites complete:

ci:test:relevant
ci:test:sf
AND If the following test suites pass:
ci:test:stable

liferay-continuous-integration · 2023-11-27T12:02:56Z

Skipping previously completed test suites:

ci:test:relevant
ci:test:sf
AND Skipping previously passed test suites:
ci:test:stable

liferay-continuous-integration · 2023-11-27T12:03:53Z

All required test suite(s) completed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2023-11-27T12:05:17Z

Pull request has been successfully forwarded to brianchandotcom#144432
Console

LPS-201682 Avoid unnecessary evaluations

07febda

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Nov 24, 2023

samuelromeiro added the High Priority This PR should be prioritized. label Nov 24, 2023

marcelabc self-assigned this Nov 24, 2023

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:forms - pending labels Nov 24, 2023

marcelabc assigned alinedoleron Nov 24, 2023

liferay-continuous-integration added ci:test:relevant - failure ci:test:forms - failure and removed ci:test:relevant - pending ci:test:forms - pending labels Nov 24, 2023

alinedoleron added the Author Action Required Changes/Questions were requested by the reviewer label Nov 24, 2023

alinedoleron suggested changes Nov 24, 2023

View reviewed changes

LPS-201682 Adding the missing required fields

537b54f

liferay-continuous-integration added ci:test:forms - failure and removed ci:test:forms - pending labels Nov 24, 2023

liferay-continuous-integration added ci:test:forms - pending ci:test:forms - failure and removed ci:test:forms - failure ci:test:forms - pending labels Nov 24, 2023

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - success ci:test:sf - pending labels Nov 27, 2023

liferay-continuous-integration mentioned this pull request Nov 27, 2023

[TS] LPS-201682 Error Message is copied over between Form Fields brianchandotcom/liferay-portal#144432

Merged

liferay-continuous-integration closed this Nov 27, 2023

IstvanD deleted the LPS-201682 branch March 9, 2026 12:24

Conversation

IstvanD commented Nov 24, 2023 • edited by marcelabc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liferay-continuous-integration commented Nov 24, 2023

Uh oh!

liferay-continuous-integration commented Nov 24, 2023

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

Uh oh!

liferay-continuous-integration commented Nov 24, 2023

Uh oh!

marcelabc commented Nov 24, 2023

Uh oh!

marcelabc commented Nov 24, 2023

Uh oh!

marcelabc commented Nov 24, 2023

Uh oh!

liferay-continuous-integration commented Nov 24, 2023

❌ ci:test:forms - 157 out of 176 jobs passed in 1 hour 33 minutes

Base Branch:

Upstream Comparison:

19 Failed Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

Uh oh!

liferay-continuous-integration commented Nov 24, 2023

Base Branch:

Job Summary:

Test bundle downloads:

Uh oh!

liferay-continuous-integration commented Nov 24, 2023

Uh oh!

liferay-continuous-integration commented Nov 24, 2023

Uh oh!

alinedoleron left a comment

Choose a reason for hiding this comment

Uh oh!

alinedoleron Nov 24, 2023

Choose a reason for hiding this comment

Uh oh!

IstvanD Nov 24, 2023

Choose a reason for hiding this comment

Uh oh!

alinedoleron commented Nov 24, 2023

Uh oh!

alinedoleron commented Nov 24, 2023

Uh oh!

alinedoleron commented Nov 24, 2023

Uh oh!

liferay-continuous-integration commented Nov 24, 2023

❌ ci:test:forms - 0 out of 1 jobs passed in 2 hours 8 minutes

Base Branch:

Upstream Comparison:

1 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

For upstream results, click here.

Test bundle downloads:

Uh oh!

liferay-continuous-integration commented Nov 24, 2023

Uh oh!

liferay-continuous-integration commented Nov 24, 2023

Uh oh!

alinedoleron commented Nov 24, 2023

Uh oh!

liferay-continuous-integration commented Nov 24, 2023

❌ ci:test:forms - 170 out of 176 jobs passed in 1 hour 54 minutes

Base Branch:

Upstream Comparison:

6 Failed Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

Uh oh!

IstvanD commented Nov 24, 2023 •

edited by marcelabc

Loading