transform: Operation based matching from spec for patching - #95
Merged
Conversation
kumarak
force-pushed
the
kumarak/patch_operations
branch
from
June 9, 2025 14:08
d2fa371 to
d5ee6b6
Compare
…pec; updated patch spec
kumarak
force-pushed
the
kumarak/patch_operations
branch
from
June 9, 2025 14:26
d5ee6b6 to
d059073
Compare
kumarak
force-pushed
the
kumarak/patch_operations
branch
2 times, most recently
from
June 10, 2025 00:58
70e5185 to
88fd963
Compare
kumarak
force-pushed
the
kumarak/patch_operations
branch
4 times, most recently
from
June 10, 2025 13:56
7d27862 to
8c58b68
Compare
kaoudis
approved these changes
Jun 10, 2025
kaoudis
left a comment
Contributor
There was a problem hiding this comment.
I have some general clarifying questions sprinkled throughout, but please do not consider them blockers.
… available in the module
kumarak
force-pushed
the
kumarak/patch_operations
branch
from
July 5, 2025 00:26
e3e947f to
284e3b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR is dependent on #94 and include the changes.
The changes perform operation based matching from the spec and perform patching operation. The Operation matching only support BeforeApply mode at the moment.
An example spec for matching cir.call operation to
spo2_lookupcan be written as below. It will check for all cir.call operation making a call tosymbol_namespo2_lookupand should be called in specific function context with pattern"/.*measurement.*/.