[pcode] refactor lifting scripts that use the Ghidra API for testability and maintainability, add tests and test environment, and add them into CI#96
Merged
Conversation
kaoudis
force-pushed
the
kaoudis/pcode-gen-correctness-tests
branch
from
July 28, 2025 20:06
c04f87a to
f7507bc
Compare
kumarak
reviewed
Jul 29, 2025
kumarak
reviewed
Jul 29, 2025
kumarak
reviewed
Jul 29, 2025
kumarak
reviewed
Jul 29, 2025
kumarak
left a comment
Collaborator
There was a problem hiding this comment.
The PR looks good and includes much needed refactoring of high pcode serializer. It seems CI is failing because of missing docker image and serializer unit tests is raise exception could be due to related reason. Should be ready to go after fixing CI.
kumarak
reviewed
Jul 31, 2025
…ity and maintainability, add tests and test environment, and add them into CI
kaoudis
force-pushed
the
kaoudis/pcode-gen-correctness-tests
branch
from
July 31, 2025 15:46
17004a4 to
6078f93
Compare
kumarak
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.