Open
Conversation
This language dates back to when there were only IPv4 and v6 descriptors. DNS got added with that change, but Tor was never updated. Zero ports never make sense, always disallow. I assume everyone does this. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this pull request
Apr 10, 2026
BOLT 7 says this, but we don't do it. (Actually, it only says that for certain types, but I've fixed that in lightning/bolts#1331). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
vincenzopalazzo
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This language dates back to when there were only IPv4 and v6 descriptors. DNS got added with that change, but Tor was never updated.
Zero ports never make sense, always disallow. I assume everyone does this.