Conversation
Adding Functions to create diagnostic figures showing bandpower topomaps and PSD plots before and after cleaning, highlighting dropped and fixed channels
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
+ Coverage 83.64% 84.50% +0.86%
==========================================
Files 26 26
Lines 1700 1717 +17
==========================================
+ Hits 1422 1451 +29
+ Misses 278 266 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks, @Deepa-Tilwani Can you push a commit that makes your patch "Black/Ruff-compliant"? You can always test your code locally using Error log from Continuous Integration: |
Style: format diagnostic.py (fix docstrings, wrap long lines), resolving ruff errors
| def process_subject_from_paths( | ||
| vhdr_path: Path, | ||
| root_clean_dir: Path, | ||
| root_pylossless_dir: Path, | ||
| out_dir: Path, | ||
| montage_path: Optional[Path] = None, | ||
| overwrite: bool = False, | ||
| ): |
There was a problem hiding this comment.
re: vhdr_path, In theory users can save pylossless output EEG data in EDF or FIF format, not just. Brainvision. can we support those too?
There was a problem hiding this comment.
I think the code should probably be refactored to be more object oriented. I wonder if there is a convenient way to have diagnostic functions being methods of the pipeline object. However, to avoid growing to much the pipeline class, maybe the pipeline class should have methods that call such external functions. Regardless, I suspect that any function here should be agnostic to the file format. I don't see any reason why it should be tied to specific file format... it should be abstracted.
There was a problem hiding this comment.
However, to avoid growing to much the pipeline class, maybe the pipeline class should have methods that call such external functions
Agreed, this is generally my preferred approach!
4 participants
Adding Functions to create diagnostic figures showing bandpower topomaps and PSD plots before and after cleaning, highlighting dropped and fixed channels