Skip to content

feat(addon/components/paper-card-actions): migrates to tagless native class.#25

Open
matthewhartstonge wants to merge 1 commit into
10-17-feat_addon_components_paper-card-image_migrates_to_tagless_native_classfrom
10-17-feat_addon_components_paper-card-actions_migrates_to_tagless_native_class
Open

feat(addon/components/paper-card-actions): migrates to tagless native class.#25
matthewhartstonge wants to merge 1 commit into
10-17-feat_addon_components_paper-card-image_migrates_to_tagless_native_classfrom
10-17-feat_addon_components_paper-card-actions_migrates_to_tagless_native_class

Conversation

@matthewhartstonge

@matthewhartstonge matthewhartstonge commented Oct 17, 2024

Copy link
Copy Markdown
Member
  • removes lifecycle hooks by moving to a computed property (getter)
  • adds integration tests

matthewhartstonge commented Oct 17, 2024

Copy link
Copy Markdown
Member Author

@matthewhartstonge
matthewhartstonge marked this pull request as ready for review October 17, 2024 04:23
@matthewhartstonge
matthewhartstonge force-pushed the 10-17-feat_addon_components_paper-card-image_migrates_to_tagless_native_class branch from ae26cd5 to b7934b1 Compare October 17, 2024 04:24
@matthewhartstonge
matthewhartstonge force-pushed the 10-17-feat_addon_components_paper-card-actions_migrates_to_tagless_native_class branch from 3a6162d to 21de1c2 Compare October 17, 2024 04:24
@matthewhartstonge
matthewhartstonge force-pushed the 10-17-feat_addon_components_paper-card-image_migrates_to_tagless_native_class branch from b7934b1 to 5f42b93 Compare October 18, 2024 04:15
@matthewhartstonge
matthewhartstonge force-pushed the 10-17-feat_addon_components_paper-card-actions_migrates_to_tagless_native_class branch from 21de1c2 to 798d619 Compare October 18, 2024 04:15
@matthewhartstonge
matthewhartstonge force-pushed the 10-17-feat_addon_components_paper-card-image_migrates_to_tagless_native_class branch from 5f42b93 to 1dd71e0 Compare October 29, 2024 21:02
@matthewhartstonge
matthewhartstonge force-pushed the 10-17-feat_addon_components_paper-card-actions_migrates_to_tagless_native_class branch from 798d619 to 3022ea9 Compare October 29, 2024 21:02
@github-actions

github-actions Bot commented Oct 29, 2024

Copy link
Copy Markdown

Some tests with 'continue-on-error: true' have failed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant