cleanup: Add no-internalModels-flag variants to methods used by GMS's#475
cleanup: Add no-internalModels-flag variants to methods used by GMS's#475
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #475 +/- ##
============================================
- Coverage 68.02% 67.87% -0.16%
Complexity 1635 1635
============================================
Files 143 143
Lines 6252 6266 +14
Branches 682 682
============================================
Hits 4253 4253
- Misses 1709 1723 +14
Partials 290 290 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @Nonnull | ||
| protected Map<URN, VALUE> getInternal(@Nonnull Collection<URN> urns, | ||
| @Nonnull Set<Class<? extends RecordTemplate>> aspectClasses) { | ||
| final boolean isInternalModelsEnabled = getResourceLix().testGetAll(_urnClass.getSimpleName()); |
There was a problem hiding this comment.
the getResourceList().testGetAll() gives low granular lix control on getAll method. Putting it inside the getInternal() will lose this granularity.
| @Nonnull | ||
| protected Map<URN, VALUE> getInternalNonEmpty(@Nonnull Collection<URN> urns, | ||
| @Nonnull Set<Class<? extends RecordTemplate>> aspectClasses) { | ||
| final boolean isInternalModelsEnabled = getResourceLix().testGetAll(_urnClass.getSimpleName()); |
There was a problem hiding this comment.
same here, unless only getAll is calling this method. But there's no restriction for future cases
yangyangv2
left a comment
yangyangv2
left a comment
There was a problem hiding this comment.
what is the motivation on this clean up?
If getResourceLix() is no longer used, better to cleanup in the original methods rather than introducing new ones.
3 participants
Summary
Add no-flag variants to methods so that consumer GMS's don't need to call "lix logic", which is confusing since there is no Lix active any more.
Non-TMS Codesearch: https://jarvis.corp.linkedin.com/codesearch/results/?query=mp%3A*-gms%20getResourceLix
TMS Codesearch: https://jarvis.corp.linkedin.com/codesearch/results?query=mp%3Ametadata-store+getResourceLix¤t=1&nresults=10
Testing Done
n/a
Checklist