Improve performance of tracker client lookup in SimpleLoadBalancer#1152
Open
idarmans wants to merge 1 commit intolinkedin:masterfrom
Open
Improve performance of tracker client lookup in SimpleLoadBalancer#1152idarmans wants to merge 1 commit intolinkedin:masterfrom
idarmans wants to merge 1 commit intolinkedin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimpleLoadBalancer#getPotentialClientscame up as a CPU hotspot in production, and 45% of the CPU usage is spent onURI#hashCode&URI#equals.The fix is in
UriLoadBalancerSubscriber#handlePut, we make sure to use the URI objects out of the incoming UriProperties in the tracker client map, such that the map look up becomes O(1) due to it falling back to identity equality. This fix only costs slightly more memory allocation during updates, with no extra heap usage in the long run.Added unit tests to cover the identity equality