usb: Allow devices with no serial number to show in the usb list#213
Open
Zephyrus29 wants to merge 1 commit intolinux-msm:masterfrom
Open
usb: Allow devices with no serial number to show in the usb list#213Zephyrus29 wants to merge 1 commit intolinux-msm:masterfrom
Zephyrus29 wants to merge 1 commit intolinux-msm:masterfrom
Conversation
Zephyrus29
force-pushed
the
bugfix/noSerial
branch
from
bedb8d4 to
ad21cdd
Compare
Collaborator
|
I think your patch looks good, but your commit subject talks about "loading" and your patch affect the listing of devices. Please clarify the intent with your patch, by describing the problem you're seeing in the commit message. |
Author
|
I can change it clarify that it affects the listing and I can change it so the serial is (none). |
Zephyrus29
force-pushed
the
bugfix/noSerial
branch
from
ad21cdd to
1c1960f
Compare
Zephyrus29
changed the title
Some devices, such as an msm8937 based one isn't reporting a serial in edl mode. This patch allows those devices to appear and be visible Signed-off-by: Nicholas Hunn <nicholas.hunn4568@gmail.com>
Zephyrus29
force-pushed
the
bugfix/noSerial
branch
from
1c1960f to
e4af514
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a module type that isn't reporting a serial number (msm8937 based).
Currently they can't load at all, this change means while they still cannot be selected by serial number, they can still load.