Add a generic 3 button + eraser pen#984
Merged
Merged
Conversation
11d883c to
42e3adb
Compare
Member
Author
|
Probably noteworthy here: I did get tempted to make this a huion-specific pen (i.e. 256c vendor id) but the amount of work required here, in libinput, in the wayland protocol, in the compositor and the clients (e.g. GNOME Settings) for what ends up being zero benefit is simply not worth it. |
This covers the Huion PW600 device which is the most flexible device that huion devices can support - it's a three-button pen with a tail-end eraser. But so far we cannot know which pen is being used so we need to implement this as a generic pen and hope that it doesn't confuse the user too much. The order (and fake tool ID) of pen and eraser shouldn't matter but we give the pen a lower tool ID than the eraser. This means during typical listing the pen comes first which helps implementations that don't correctly check whether the tool is an eraser.
From Huion's website [1]: Compatible with Kamvas Pro 19 and Kamvas Pro 27, Kamvas 16 (Gen 3) and Kamvas 13 (Gen 3) This produces false positives if a user doesn't have that tool - we still cannot identify Huion pens at runtime. But better to have configuration for buttons that don't exist than lacking configurations for buttons that do exist. [1] https://store.huion.com/au/products/battery-free-pen-pw600 Assisted-by: Claude:claude-opus-4-6
42e3adb to
e7d9d07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sits on top of #983
This covers the Huion PW600 device which is the most flexible device
that huion devices can support - it's a three-button pen with a tail-end
eraser. But so far we cannot know which pen is being used so we need to
implement this as a generic pen and hope that it doesn't confuse the
user too much.
The order (and fake tool ID) of pen and eraser shouldn't matter but we
give the pen a lower tool ID than the eraser. This means during typical
listing the pen comes first which helps implementations that don't
correctly check whether the tool is an eraser
(e.g. GNOME Settingsedit: this is #985as of GNOME 50).
The tablets switch to the new pen are the ones listed on Huion's website 1:
This produces false positives if a user doesn't have that tool - we
still cannot identify Huion pens at runtime. But better to have
configuration for buttons that don't exist than lacking configurations
for buttons that do exist.
Footnotes
https://store.huion.com/au/products/battery-free-pen-pw600 ↩