Remove unnecessary WCM_PAD flag and clean up WCM_LCD#366
Merged
Conversation
whot
approved these changes
Oct 14, 2025
whot
left a comment
whot
left a comment
Member
There was a problem hiding this comment.
github doesn't let me comment on commit messages but: festure verification looks like a typo :) Can you please fix that message, thanks. LGTM otherwise
added 2 commits
October 15, 2025 11:05
Rely on INPUT_PROP_DIRECT which is passed directly from the kernel driver. Keep the WCM_LCD flag as defined for feature verification. Signed-Off-By: Ping Cheng <ping.cheng@wacom.com>
The flag is not used anywhere in the code. The PAD interface is decided in wcmConfig and wcmUSB. Signed-Off-By: Ping Cheng <ping.cheng@wacom.com>
Pinglinux
force-pushed
the
wcm_lcd_cleanup
branch
from
5957445 to
f5469a8
Compare
Member
Author
|
@whot Thank you Peter for your attention to the details. The commit comments have been fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We rely on kernel INPUT_PROP_DIRECT to tell us if the tablet is a display tablet or not. No need to keep those hard coded checks for this flag. The WCM_PAD is not used for anything now. Remove it too.