Refactor: rename .c source files to .cpp#127
Merged
Merged
Conversation
All source files were already compiled as C++ — this commit makes the extensions reflect that. The immediate motivation is to simplify the CMake migration: with a uniform .cpp extension CMake needs no language override and the source discovery logic is straightforward. Update linux/makefile (remove dead .c pattern rule, fix testblt target), ms/projects/*.vcxproj, and linux/build_makefile_inc.py to match. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds the sha of 79a6590 (rename .c -> .cpp) so that git blame skips the mechanical rename and attributes lines to their true authors. Run once per clone to activate: git config blame.ignoreRevsFile .git-blame-ignore-revs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Merging now as I need a fix for a race condition in the workflow without having to change the recorded sha hash. Can unwind if that doesn't fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All source files were already compiled as C++ — this commit makes the
extensions reflect that. The immediate motivation is to simplify the
CMakemigration: with a uniform.cppextensionCMakeneeds no languageoverride and the source discovery logic is straightforward.
Update
linux/makefile(remove dead.cpattern rule, fixtestblttarget),ms/projects/*.vcxproj, andlinux/build_makefile_inc.pyto match.Add the sha so that
git blamecan skip the mechanical rename andattributes lines to their true authors:
git config blame.ignoreRevsFile .git-blame-ignore-revsGSR-966