New-cookie-api - #666
Closed
mikelxk wants to merge 3 commits into
Closed
Conversation
mikelxk
force-pushed
the
new-cookie-api
branch
from
October 23, 2021 23:29
a02ce93 to
254be8a
Compare
mikelxk
marked this pull request as draft
October 24, 2021 17:45
Owner
|
nice try to solve chrome cookie api is not available. The only problem is this api require chrome v87+ is a little too new. I think we can use it if there's no plan B. Another way to work around is extracting cookie related logic to new module and call this module in dev server (when proxying request), or make music platform api to independent module, which support call by function api and network api. I'm still thinking about details. |
Collaborator
Author
|
I don't think the cookieStore is applicable for now because it can't be set under given domain. We need a backend support for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use new cookie api to resolve issue in #661