refactor(litmus): adding "ns.svc.cluster.local" to urls#371
Open
jlplasce wants to merge 2 commits intolitmuschaos:masterfrom
Open
refactor(litmus): adding "ns.svc.cluster.local" to urls#371jlplasce wants to merge 2 commits intolitmuschaos:masterfrom
jlplasce wants to merge 2 commits intolitmuschaos:masterfrom
Conversation
Adding full service fqdn to the end of service urls to assist with proxied environments Signed-off-by: Jose Plascencia <plascencia_jose@bah.com>
Member
|
Hi @jlplasce, thank you for submitting the pull request! It appears there are some conflicts that likely stem from version bumps. Could you please take a moment to resolve these? If you need any assistance, feel free to reach out. Thanks! |
|
Any updates on this? |
|
This is our current workaround kusomize patch: apiVersion: v1
kind: Deployment
metadata:
name: patch
spec:
template:
spec:
containers:
- name: graphql-server
env:
- name: http_proxy
value: http:/our internal proxy
- name: https_proxy
value: http://our internal proxy
- name: no_proxy
value: localhost,127.0.0.1,10.0.0.0/8,*.cluster.local.,*.cluster.local,litmus-chaoscenter-server-service,litmuschaoscenter-auth-server-service,litmuschaoscenter-frontend-service,litmuschaoscenter-mongodb-arbiter-headless,litmuschaoscenter-mongodb-headless
- name: HTTP_PROXY
value: http://our internal proxy
- name: HTTPS_PROXY
value: http://our internal proxy
- name: NO_PROXY
value: localhost,127.0.0.1,10.0.0.0/8,*.cluster.local.,*.cluster.local,litmus-chaoscenter-server-service,litmuschaoscenter-auth-server-service,litmuschaoscenter-frontend-service,litmuschaoscenter-mongodb-arbiter-headless,litmuschaoscenter-mongodb-headless |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding full service fqdn to the end of service urls to assist with proxied environments
What this PR does / why we need it:
In proxied environments, you can get Litmus to operate properly by setting proxies in the environment args. However, the service names are hardcoded just to the service name itself without any FQDN (i.e. "http://litmus-server-service:9002/") which will inadvertently send the traffic through the Proxy.
Typically, in these proxied environments you'd put "cluster.local" in the
no_proxysetting so internal cluster traffic is not proxied - since the service names are not a full domain path, we run in to issues. This PR appends the standard ".svc.cluster.local" to the nginx pass URLs as well as the DB_SERVER urls so that connection to those services are caught by theno_proxysettingsWhich issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]