-
Notifications
You must be signed in to change notification settings - Fork 334
feat(tts): add Fish Audio expressive markup #2190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rosetta-livekit-bot
wants to merge
1
commit into
claude/new-session-r2y2aw
Choose a base branch
from
rosemary-apprized-quietude
base: claude/new-session-r2y2aw
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@livekit/agents': minor | ||
| --- | ||
|
|
||
| Add Fish Audio s2 expressive markup and speech steering support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Expressive speech markers are turned on for every Fish Audio voice, not only the models that understand them
Expressive markup is enabled for any Fish Audio voice by keying only on the provider prefix (
_markupProviderKey()atagents/src/inference/tts.ts:387-395), even though the new markers are only understood by the s2 family, so older Fish voices get emotion/sound/pause markers they cannot interpret.Impact: A user running an older Fish Audio voice with expressive mode can hear bracketed marker text read aloud or get garbled delivery.
Provider-key derivation vs. the s2-only marker vocabulary
PROVIDER_MARKUP/llmInstructionsgain afishaudioentry (agents/src/tts/_provider_format.ts:983-1001), and the vocabulary is explicitly documented as the "Fish Audio (s2 family) speech markers" (agents/src/tts/_provider_format.ts:120). ButInferenceTTS._markupProviderKey()returns the raw provider segment of the model string for anything other than Inworld, which already has exactly this kind of gate (return model.includes('tts-2') ? 'inworld' : ''). Consequentlyfishaudio/s1,fishaudio/s1-mini, etc. also resolve to'fishaudio', so_resolveExpressiveOptions()(agents/src/voice/agent_activity.ts:1917) sees markup support, the LLM is instructed to emit<expr .../>markers, andconvertMarkuplowers them to[very excited],[laughing],[break],[emphasis]before they are sent to a model that does not implement them.A model gate mirroring the Inworld one (only s2 models return
'fishaudio') would restore the intended scope.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.